[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor benchmark scripts #1907

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Refactor benchmark scripts #1907

merged 1 commit into from
Jul 30, 2024

Conversation

charleskawczynski
Copy link
Member

This PR refactors two of our benchmark scripts by:

  • Removing latency by avoiding syncs per call, this should better represent performance in practice.
  • Moved some utilities to a separate file
  • Add benchmarks to CI
  • Report hardware bandwidth efficiency in benchmark
  • Use tabular format for easier to read output.
  • Put majority of code inside a module to ensure no use of global variables

Next I'll update the thermo benchmark.

@charleskawczynski charleskawczynski force-pushed the ck/benchmark_script_updates branch 2 times, most recently from 8181b44 to f3c6623 Compare July 30, 2024 14:26
@charleskawczynski charleskawczynski merged commit 09ae4ca into main Jul 30, 2024
4 of 9 checks passed
@charleskawczynski charleskawczynski deleted the ck/benchmark_script_updates branch July 30, 2024 14:46
Sbozzolo
Sbozzolo reviewed Jul 30, 2024
View reviewed changes
benchmarks/scripts/indexing_and_static_ndranges.jl
@@ -5,7 +5,7 @@ using Revise; include(joinpath("benchmarks", "scripts", "indexing_and_static_ndr
# Info:
This script compares two things:
- linear vs cartesian indexing
- impact of static vs dynamic NDRanges (https://juliagpu.github.io/KernelAbstractions.jl/dev/examples/memcopy_static/)
- impact of static vs dynamic NDRanges (https://juliagpu.githubSR.io/KernelAbstractions.jl/dev/examples/memcopy_static/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some search and replace going wrong here (and below)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, I’ll fix this up, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo left review comments

Assignees
No one assigned
Labels
Performance monitoring 🔍🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charleskawczynski @Sbozzolo