[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hyperbolic tangent stretching #3260

Merged
merged 1 commit into from
Sep 12, 2024
Merged

use hyperbolic tangent stretching #3260

merged 1 commit into from
Sep 12, 2024

Conversation

szy21
Copy link
Member
@szy21 szy21 commented Aug 22, 2024

Purpose

Switch to hyperbolic tangent stretching. Closes #3239

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/stretching branch 2 times, most recently from 434e840 to 4fd7173 Compare August 23, 2024 21:36
@szy21 szy21 force-pushed the zs/stretching branch 3 times, most recently from 00bd37b to 129762f Compare September 11, 2024 06:32
@szy21 szy21 force-pushed the zs/stretching branch 4 times, most recently from 2be12ae to 76a0168 Compare September 12, 2024 17:21
@szy21 szy21 changed the title use tangent hyperbolic stretching use hyperbolic tangent stretching Sep 12, 2024
@szy21 szy21 marked this pull request as ready for review September 12, 2024 17:22
@szy21
Copy link
Member Author
szy21 commented Sep 12, 2024

longrun build:
https://buildkite.com/clima/climaatmos-gpulongruns/builds/388
https://buildkite.com/clima/climaatmos-gpulongruns/builds/391

The topography run breaks but I think we can reevaluate it when working on warping and SLEVE coordinate.

@szy21 szy21 force-pushed the zs/stretching branch 2 times, most recently from 1262ef7 to 5850395 Compare September 12, 2024 18:22
Copy link
Member
@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szy21 This change is reasonable; Minor comments on existing longruns and z_elem in one of the single column tests.

@szy21 szy21 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 8eddb0b Sep 12, 2024
14 of 16 checks passed
@szy21 szy21 deleted the zs/stretching branch September 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use hyperbolic tangent stretching
2 participants