-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max-player property on proxies too #419
Conversation
This might require a bit more handling, as the max players could be changed in the proxy ping event. We handle that for servers, so it might be good for proxies too. Altough calling the ping event to get the max players is a bit weird. |
Well, we were thinking about the Ping Event. But that would cause problems with the SyncProxy Max Players.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That would not cause problems with SyncProxy, it's the other way around: CloudNet would detect and use the max player amount set by SyncProxy, which is the correct behavior. The problem with this currently is, that the max players in the bungee config are mostly ignored and replaced via the ping event. If CloudNet would call that event, the same way it does on servers, everything should be fine. |
What CloudNet could do too is to add an event handler with highest priority to get the max players from the event. That would work if no other plugin modifies the max players in this priority. |
This would not work in the correct way with the SmartModule. When the amount of the SyncProxy Module is used (e.g. 1000) the SmartModule would use this global amount for starting a new proxy. (And not for example 100 for each Proxy) |
|
Nevermind my previous idea, this would prevent the dynamic change of the max players with the API (or the max players used by the smart module)... |
This pull request includes:
Changes made to the repository:
Added the Max-Players property also to proxies