[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error on missing generics parameter in entry_points macro #405

Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat: Error on missing generics parameter in entry_points macro #405

merged 2 commits into from
Jul 31, 2024

Conversation

jawoznia
Copy link
Collaborator

Additionally there is some refactor done. Some code could be reused. Also, MsgVariants generated some code it should not.

@jawoznia
Copy link
Collaborator Author

Kudos to @abefernan for pointing to the missing error ;)

@codecov Codecov
Copy link
codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (d4c94ca) to head (8f6d1f6).

Files Patch % Lines
sylvia-derive/src/message.rs 0.00% 68 Missing ⚠️
sylvia-derive/src/parser/entry_point.rs 0.00% 10 Missing ⚠️
sylvia/tests/ui/macros/entry_points.rs 0.00% 6 Missing ⚠️
sylvia-derive/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   85.15%   85.33%   +0.17%     
==========================================
  Files          41       42       +1     
  Lines        2911     2905       -6     
==========================================
  Hits         2479     2479              
+ Misses        432      426       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia
Copy link
Collaborator Author

#397

hashedone

This comment was marked as spam.

Sign in to view

hashedone

This comment was marked as spam.

Sign in to view

hashedone
hashedone approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator
@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit 7b6d2ce into main Jul 31, 2024
6 of 7 checks passed
@jawoznia jawoznia deleted the jawoznia/entry_points_errors branch July 31, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone