pkg/trace/agent: consider UTF-8 characters in tags #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a problem in NormalizeTag where it was assuming
character lengths to be always equal to 1, whereas this isn't always
true for UTF-8 characters.
It also fixes an issue where not all Unicode letters were lower-cased.
Performance remains virtually unimpacted.
name old time/op new time/op delta
NormalizeTag/ok-4 68.8ns ± 0% 69.2ns ± 0% +0.58%
NormalizeTag/trim-4 92.8ns ± 0% 92.5ns ± 0% -0.32%
NormalizeTag/trim-both-4 159ns ± 0% 163ns ± 0% +2.52%
NormalizeTag/plenty-4 147ns ± 0% 150ns ± 0% +2.04%
NormalizeTag/more-4 259ns ± 0% 270ns ± 0% +4.25%
name old alloc/op new alloc/op delta
NormalizeTag/ok-4 24.0B ± 0% 24.0B ± 0% 0.00%
NormalizeTag/trim-4 32.0B ± 0% 32.0B ± 0% 0.00%
NormalizeTag/trim-both-4 64.0B ± 0% 64.0B ± 0% 0.00%
NormalizeTag/plenty-4 64.0B ± 0% 64.0B ± 0% 0.00%
NormalizeTag/more-4 128B ± 0% 128B ± 0% 0.00%
name old allocs/op new allocs/op delta
NormalizeTag/ok-4 2.00 ± 0% 2.00 ± 0% 0.00%
NormalizeTag/trim-4 2.00 ± 0% 2.00 ± 0% 0.00%
NormalizeTag/trim-both-4 3.00 ± 0% 3.00 ± 0% 0.00%
NormalizeTag/plenty-4 3.00 ± 0% 3.00 ± 0% 0.00%
NormalizeTag/more-4 4.00 ± 0% 4.00 ± 0% 0.00%
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
+ Coverage 56.53% 56.54% +0.01%
==========================================
Files 484 484
Lines 34250 34260 +10
==========================================
+ Hits 19362 19373 +11
+ Misses 13727 13726 -1
Partials 1161 1161
|
AlexJF
reviewed
Jan 29, 2019
AlexJF
reviewed
Jan 29, 2019
AlexJF
reviewed
Jan 29, 2019
|
Thanks Alex! Great learnings here! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a problem in NormalizeTag where it was assuming character lengths to be always equal to 1, whereas this isn't always true for UTF-8 characters.
It also fixes an issue where not all Unicode letters were lower-cased.
Performance remains virtually unimpacted.
In addition to #2951