contrib: standardize span types #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a set of `SpanType*` constants to the `ext` package outlining all the possible span types that are currently used or can be used by the agent. It also updates the entire codebase to make use of these constants wherever possible. The remaining `AppType*` constants are being discouraged from usage and should be used only to categorize traces in the UI when no better alternative exists.
46d0f93
to
a392d12
Compare
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
* all: standardize span types This change adds a set of `SpanType*` constants to the `ext` package outlining all the possible span types that are currently used or can be used by the agent. It also updates the entire codebase to make use of these constants wherever possible. The remaining `AppType*` constants are being discouraged from usage and should be used only to categorize traces in the UI when no better alternative exists. * ddtrace/ext: add fool-proof test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a set of
SpanType*constants to theextpackageoutlining all the possible span types that are currently used or can be
used by our pipeline. It also updates the entire codebase to make use of
these constants wherever possible.
The remaining
AppType*constants are being discouraged from usage andshould be used only to categorize traces in the UI when no better
alternative exists.