[go: nahoru, domu]

Skip to content

Commit

Permalink
Update a TODO with issue number (flutter#17494)
Browse files Browse the repository at this point in the history
Further digging revealed that the reason --no-sim-use-hardfp was
required to be specified explicitly was that Android engine gen_snapshot
binaries are built on Windows with target_os=win.
  • Loading branch information
cbracken committed May 11, 2018
1 parent 1e5579e commit adf8ffc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/flutter_tools/lib/src/base/build.dart
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class AOTSnapshotter {
if (platform == TargetPlatform.android_arm || iosArch == IOSArch.armv7) {
// Use softfp for Android armv7 devices.
// Note that this is the default for armv7 iOS builds, but harmless to set.
// TODO(cbracken) use TargetPlatform-specific gen_snapshot for Android so that this is defaulted.
// TODO(cbracken) eliminate this when we fix https://github.com/flutter/flutter/issues/17489
genSnapshotArgs.add('--no-sim-use-hardfp');

// Not supported by the Pixel in 32-bit mode.
Expand Down

0 comments on commit adf8ffc

Please sign in to comment.