[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose nginx status to prometheus in Kubernetes (helm) #3260

Merged
merged 5 commits into from
Dec 13, 2020

Conversation

uncycler
Copy link
Contributor

This PR add the possibility to expose nginx status to prometheus using the nginx prometheus exporter. For doing so, I had to disable metrics basic auth for localhost to allow the exporter to access the nginx status endpoint.

KUBERNETES.md Outdated
@@ -308,6 +308,10 @@ However, that doesn't work and I haven't found out why. In a production
environment, a redundant PostgreSQL cluster is the better option. As it uses
statefulsets that are kept by default, the problem doesn't exist there.

### Prometheus metrics

It's possible to enable Nginx prometheus exporter by setting `--set monitoring.enabled=true` and `--set monitoring.prometheus.enabled=true`. This is add the Nginx exporter sidecar and and the standard pod annotations to django deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is add --> This adds

and and --> and

Copy link
Contributor
@madchap madchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the PR.

@alles-klar
Copy link
Contributor

@uncycler please set target branch to dev

@valentijnscholten valentijnscholten changed the base branch from master to dev December 13, 2020 17:42
@valentijnscholten
Copy link
Member

@alles-klar I've changed the base branch of the PR and still looks good. Can you merge if you agree?

@alles-klar alles-klar merged commit 0d7c38b into DefectDojo:dev Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants