Implement rate limiting reply snac

DrewML · Dec 27, 2020 · beff505 · beff505
1 parent f0da6aa
commit beff505
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/BossServer/index.ts b/src/BossServer/index.ts
@@ -43,7 +43,6 @@ export class BossServer extends OscarServer {
             }
 
             if (matchSnac(snac, 'GENERAL', 'RATE_INFO_REQUEST')) {
-                assert(false, 'snac 01,07 not implemented yet');
                 return oscarSocket.write({
                     type: FlapType.DATA,
                     data: rateLimitInfoSnac({ reqID: snac.requestID }),

diff --git a/src/BossServer/serverSnacs.ts b/src/BossServer/serverSnacs.ts
@@ -36,6 +36,11 @@ export function supportedFamiliesSnac(opts: { reqID: number }) {
  * @see http://iserverd.khstu.ru/oscar/snac_01_18.html
  */
 export function familyVersionsSnac(opts: { reqID: number }) {
+    // Note: The official Oscar protocol docs claim something
+    // completely different for this snac. But the unofficial
+    // docs seem to be correct (weird)
+    // http://web.archive.org/web/20080308233204/http://dev.aol.com/aim/oscar/#OSERVICE__MIGRATE_GROUPS
+
     // prettier-ignore
     const versions = uint16BEBuffer([
         // family, version
@@ -62,11 +67,24 @@ export function familyVersionsSnac(opts: { reqID: number }) {
 }
 
 /**
+ * @description Create a SNAC specifying the server-enforced
+ *              rate limits. Note that this server currently
+ *              doesn't enforce rate limits, this is just a
+ *              necessary part of the signon process
  * @see http://iserverd.khstu.ru/oscar/snac_01_07.html
+ * @see http://web.archive.org/web/20060113101258/http://joust.kano.net/wiki/oscar/moin.cgi/RateLimiting
+ * @see http://web.archive.org/web/20080308233204/http://dev.aol.com/aim/oscar/#RATELIMIT
  */
 export function rateLimitInfoSnac(opts: { reqID: number }) {
-    // TODO: hardcode a giant buffer here
-    const data = Buffer.alloc(0);
+    // prettier-ignore
+    const data = Buffer.from([
+        0x0, 0x0, // uint16, number of rate classes
+        // Here is where all the rate classes would normally go.
+        // Luckily we can save a bunch of time because AIM clients
+        // (at least 5.2) will accept 0 total rate classes, as far
+        // as I can tell. Will likely implement proper rate classes
+        // when the server itself has rate limiting functionality
+    ]);
 
     return buildSnac({
         family: SNACS.GENERAL.family,