-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add categories in RPC documentation #7485
Add categories in RPC documentation #7485
Conversation
e2aa506
to
24e0707
Compare
20c04a6
to
19afa12
Compare
19afa12
to
5e8f690
Compare
5e8f690
to
72c4775
Compare
…m plugin_command struct Changelog-None.
72c4775
to
c8698fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack c8698fe
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation ElementsProject#7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-None.
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation ElementsProject#7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation #7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad this breaks new plugins from running on older nodes. For example renepay compiled on the master branch after this PR a82f1fe, will not run on v24.05, because description will be missing from the getmanifest response.
readonly
category forget
&list
commands exceptlistdatastore
category
andverbose
from json_command structuredescription
from json_command structurecategory
,description
andlong_description
from plugin_command structChangelog-None.