[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendpay with blindedpath #7493

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Lagrang3
Copy link
Collaborator

Add extra arguments to sendpay to handle bolt12's blinded paths.

Add the possiblity to parse from command line arguments a struct
blinded_path.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Uniformly serialize blinded paths' field "path" instead of "hops".

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@@ -35,7 +35,7 @@ json_to_blinded_path(const tal_t *ctx, const char *buffer, const jsmntok_t *tok)
else
sciddir_or_pubkey_from_pubkey(&rpath->first_node_id, &first_node_id);

hops = json_get_member(buffer, tok, "hops");
hops = json_get_member(buffer, tok, "path");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustyrussell: I am not sure about this, should it be "hops" or "path".

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3 Lagrang3 marked this pull request as ready for review July 31, 2024 07:39
@Lagrang3
Copy link
Collaborator Author

There are some files autogenerated after I hit make:

	modified:   .msggen.json
	modified:   cln-grpc/proto/node.proto
	modified:   cln-grpc/src/convert.rs
	modified:   cln-rpc/src/model.rs
	modified:   contrib/msggen/msggen/schema.json
	modified:   contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
	modified:   contrib/pyln-grpc-proto/pyln/grpc/node_pb2_grpc.py
	modified:   contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py
	modified:   doc/index.rst

some of which are related to my changes, but others are not. I don't know if I should commit them too.

Changelog-Added: offers: sendpay RPC now accepts a blinded paths to execute a BOLT12 payment.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3
Copy link
Collaborator Author

I had a mistake in the schema, rebased on top of that commit.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@daywalker90
Copy link
Contributor

doc/index.rst looks new to me but i think that's ok. Rest is business as usual if you change something in the schema.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3 Lagrang3 requested a review from cdecker as a code owner July 31, 2024 12:20
@Lagrang3
Copy link
Collaborator Author
Lagrang3 commented Aug 6, 2024

Related to #6609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants