-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: gossip status support #7502
Open
rustyrussell
wants to merge
12
commits into
ElementsProject:master
Choose a base branch
from
rustyrussell:guilt/gossip_status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Experimental: gossip status support #7502
rustyrussell
wants to merge
12
commits into
ElementsProject:master
from
rustyrussell:guilt/gossip_status
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ec301e
to
c4f259d
Compare
…map topology. Simple format, which doesn't include node information, just the channels. Example: ``` $ ls -l gossip-store-2024-06-26 -rw------- 1 rusty rusty 98815543 Jul 26 09:47 gossip-store-2024-06-26 $ ./devtools/gossmap-compress -v compress gossip-store-2024-06-26 compressed 18693 nodes 61437 channels 46148 disabled channels (32620 no update) 9690 unique capacities 85 unique htlc_min 6867 unique htlc_max 807 unique basefee 2521 unique propfee 94 unique delay $ ls -l compressed -rw-rw-r-- 1 rusty rusty 1643258 Jul 26 09:51 compressed ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ble. Before: ``` -rw-rw-r-- 1 rusty rusty 1643258 Jul 26 09:51 compressed ``` After: ``` -rw-rw-r-- 1 rusty rusty 508332 Jul 26 09:49 compressed ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We marshal it into the "compressed" format and get the decompresser to build the actual gossmap. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This helps code using generate_gossip_store() too, since it can map its identifiers to the nodeids which were used. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We add 100 to feature bit, and 30,000 to the message number, for experimentation. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This allows us to answer questions about the quantity of node announcements and channel updates without a traversal. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
If they seem to be far behind, we send all the gossip. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
printwire_bigsize is not the same as printwire_u64! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
c4f259d
to
e783c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
gossip
needs-rebase
protocol
These issues are protocol level issues that should be discussed on the protocol spec repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #7495 )
I noticed my node had fallen behind on gossip. Rather than play blindly with heuristics, or wait for gossip v2, I have proposed a simple "status" message so peers can feed us a pile of gossip if they can tell we're behind.
See lightning/bolts#1186