[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC-plugin rcgen update #7503

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

michael1011
Copy link
Contributor
@michael1011 michael1011 commented Jul 29, 2024

Related to #7496

Imho updating the dependency is more elegant than pinning an older version of the Rust compiler. Especially in cases when people compile CLN themselves, they probably don't want to switch Rust versions if they even know that it would solve the compiler error.

The version of rcgen that was used before does not compile with
the latest stable Rust release v1.80
@cdecker
Copy link
Member
cdecker commented Jul 29, 2024

ACK 1dcbf0a

Agreed that it is better not to pin it, and that upgrading to a compatible version of the library is better, however, the issue here is that the CI ought to tell us reliably if the code we are changing still passes CI, and so any unrelated breakage adds to the overhead. So it might be ok to run with a fixed version on PRs and use stable in cron-based runs on master so we learn if the dependencies under us are shifting, without impacting the critical PR path (submit -> test -> fix -> test -> ...). How does that sound?

@michael1011
Copy link
Contributor Author

Yes, in theory I agree. But this is the only incident of a breaking regression in the Rust stable version in CLN I am aware of. Correct me if I am wrong.

Do you want to run against a pinned Rust version (which someone needs to update regularly) for PRs and pushed commits and introduce a new workflow with Rust stable (which someone needs to maintain) just because of this single incident? I feel like the introduced overhead by that added complexity in the CI is not justified. Especially because we are talking about a regression in the Rust compiler here.

@cdecker
Copy link
Member
cdecker commented Jul 29, 2024

Nah. Let's just keep it in mind for if it becomes an issue, you're right 👍

@cdecker cdecker merged commit 46c3920 into ElementsProject:master Jul 31, 2024
36 checks passed
@michael1011 michael1011 deleted the grpc-rcgen-update branch July 31, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants