[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-bins: Upgrade tonic to v0.12 for v0.1.8 #7597

Conversation

nepet
Copy link
Collaborator
@nepet nepet commented Aug 21, 2024

Upgrade tonic to v0.12 for rust bins v0.1.8

Description

This PR upgrades the tonic dependency of the rust libraries to v0.12. Latest version used was v0.8. Tonic had some major bugfixes in between these versions. We need to upgrade tonic for downstream consumers of our libs to be able to upgrade tonic as well.

This PR also introduces a new versioning scheme where we bump the minor semver version on any breaking api change such as the removal of deprecated calls as well as changes to the requirements of fields.

The whole rust lib stack cln-grpc cln-rpc cln-plugin and cln-grpc-plugin is now on v0.2.x, on top of tag cln v24.02.2 for the underlying message scheme.

@nepet nepet requested a review from cdecker as a code owner August 21, 2024 12:51
@nepet nepet changed the title Rust-bins: Upgrade tonic to v0.12 Rust-bins: Upgrade tonic to v0.12 for v0.1.8 Aug 21, 2024
@ShahanaFarooqui ShahanaFarooqui force-pushed the cln-rust-bins-v0.2-upgrade-tonic-version branch from 2140774 to 9a16a65 Compare September 10, 2024 00:25
@ShahanaFarooqui ShahanaFarooqui changed the base branch from cln-rust-bins-v0.2 to master September 10, 2024 00:27
@ShahanaFarooqui ShahanaFarooqui changed the base branch from master to cln-rust-bins-v0.2 September 10, 2024 00:31
Tonic had some breaking changes since 0.8. We want to be closer to newer
versions for downstream consumers to be able to benefit from changes in tonic.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
We bump the version to minor version 0.2 to allow ourselves to bump on
patch level when we need to fix a bug or update a dependency.

Changelog-Changed: Plugins: `cln-grpc` Upgrade tonic version and
introduce new versioning scheme.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@ShahanaFarooqui ShahanaFarooqui force-pushed the cln-rust-bins-v0.2-upgrade-tonic-version branch from 9a16a65 to 665fe1a Compare September 10, 2024 00:53
@nepet
Copy link
Collaborator Author
nepet commented Sep 10, 2024

Thanks for rebasing @ShahanaFarooqui, but rebasing on master will change the API that is used by the rust crates version v0.1.8. v0.1.8 points to 12f50ee which is based on core lightning version v24.02.

The reason for this PR was to bump the version to a new minor version that allows us to upgrade dependencies (like tonic from v0.1.8 to v0.12.0 in this case) on patch versions and we used two different target branches for #7597 and #7598 to update the dependencies of v0.1.8 separately from v0.1.9 as greenlight is using v0.1.8 for compatibility reasons at the moment.

However, it turned out that the reason for an "urgent" update of the tonic crate disappeared and since greenlight will eventually use a newer version of the rust crates, this PR became unnecessary.

Let's just bump the rust crates form v0.1.9 to v0.2.0 together with the tonic upgrade on #7598 and drop this PR toghether with a comlicated update strategy on different branches.

@nepet
Copy link
Collaborator Author
nepet commented Sep 10, 2024

Closed, moved to #7598

@nepet nepet closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant