uses shutil.move instead of copy and unlink #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcalacoci
requested changes
Jul 8, 2024
gcalacoci
reviewed
Jul 8, 2024
|
The only thing I'd like to see added is a note to the docs regarding the performance, but conversations are happening inside the team to redesign the whole docs, so I'm going to add an internal ticket for us to track this little piece of doc changes to the architecture part. |
martinmarques
approved these changes
Jul 15, 2024
barthisrael
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up serving wal-files from the spool-directory, in case
pg_waland the spool-directory are on the same filesystem, as in this case the file is renamed instead of copied.If those directories are on different file-systems, this doesn't change anything, as
shutil.movewill do the same 2-step-process (copy and remove) in that case. Docs for reference.Also see ticket #943