Add zstd compression via command line utility only. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Custom compression bug referenced here seems to be fixed in #588 but native |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zstd is a lot faster than gzip or bzip2, so it should be an option. This patch adds zstd compression via command line utility only because I don't know what's the policy on dependencies to external python libraries. I'm guessing it's not very desirable.
Currently zstd (or any other) compression can be used via custom compression setting, but there's a race problem with that. It seems (to me) that when custom compression is turned on all unidentified WAL files are treated as compressed with custom compression. However, files which are still in the
streamingdirectory aren't compressed at all. So if a client requests them (my clients do, this is not theoretical) then the decompression utility spits an error and Postgres doesn't start.So I'd like to add zstd compression as a first class citizen.