[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync hash api with ark-sponge #50

Closed
wants to merge 4 commits into from
Closed

sync hash api with ark-sponge #50

wants to merge 4 commits into from

Conversation

zhenfeizhang
Copy link
Contributor
@zhenfeizhang zhenfeizhang commented Apr 4, 2022 •
edited
Loading

Description

closes: #15

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@zhenfeizhang zhenfeizhang self-assigned this Apr 4, 2022
chancharles92
chancharles92 reviewed Apr 5, 2022
View reviewed changes
rescue/src/sponge.rs Outdated Show resolved Hide resolved
@zhenfeizhang zhenfeizhang mentioned this pull request Apr 5, 2022
Open
@zhenfeizhang zhenfeizhang marked this pull request as ready for review April 5, 2022 22:02
@zhenfeizhang zhenfeizhang changed the title sync hash api with ark-sponge and commitable sync hash api with ark-sponge Apr 5, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tessico tessico mentioned this pull request Nov 25, 2022
Merged
6 tasks
@alxiong
Copy link
Contributor
alxiong commented Nov 30, 2022

flavoring #146

@alxiong alxiong closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 left review comments

@alxiong alxiong Awaiting requested review from alxiong alxiong is a code owner

Assignees

@zhenfeizhang zhenfeizhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ark-sponge compatibilty
4 participants
@zhenfeizhang @CLAassistant @alxiong @chancharles92