[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve or Replace @ts-ignore #435

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Resolve or Replace @ts-ignore #435

merged 4 commits into from
Sep 1, 2021

Conversation

justjish
Copy link
Contributor

Description

  1. Reordered error checking for SdkProvider so that it will actually throw error for no sdk provided.
  2. Resolve @ts-ignore in SdkProvider: v9 exposes props.sdk.app.name for all SDKs, so used that for app name comparison.
  3. For the remaining ts-ignores, replaced with @ts-expect-error.

Code sample

@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@jhuleatt
Copy link
Collaborator
jhuleatt commented Aug 29, 2021 •
edited
Loading

Thanks for this cleanup @sujishpatel! Can you please run yarn docs from the root of the project to make that last check go green?

(Sorry that wasn't clear. I've updated the contributing guide to make it easier for future contributors).

@jhuleatt
Copy link
Collaborator
jhuleatt commented Sep 1, 2021

Thank you @sujishpatel!

@jhuleatt jhuleatt merged commit 24320c4 into FirebaseExtended:main Sep 1, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhuleatt jhuleatt jhuleatt approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justjish @jhuleatt