[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useAnalytics missing in ReactFire v4 #429 #431

Merged
merged 7 commits into from
Aug 26, 2021

Conversation

shiiinji
Copy link
Contributor

Description

useAnalytics missing in ReactFire v4

Code sample

@google-cla
Copy link
google-cla bot commented Aug 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 26, 2021
@shiiinji
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 26, 2021
Copy link
Collaborator
@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shiiinji! I've left a few comments, but once they're resolved I'd be happy to merge this.

docs/use.md Outdated Show resolved Hide resolved
docs/use.md Outdated Show resolved Hide resolved
example/withoutSuspense/Analytics.tsx Outdated Show resolved Hide resolved
"@firebase/analytics-types" "0.7.0-2021720181311"
"@firebase/component" "0.5.6-2021720181311"
"@firebase/util" "1.3.0-2021720181311"
"@firebase/analytics-compat@0.1.0":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that the lockfile changed! I'm going to push a separate commit to fix this, since it's not related to the scope of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks.

Copy link
Collaborator
@jhuleatt jhuleatt Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the commit on the main branch: cc0c93e

shiiinji and others added 3 commits August 27, 2021 00:09
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
@shiiinji
Copy link
Contributor Author

Thank you @shiiinji! I've left a few comments, but once they're resolved I'd be happy to merge this.

I appreciate your great feedbacks.
I resolved the issues.

@jhuleatt
Copy link
Collaborator

One more change - can you please run yarn docs at the root of the repository? That will auto-generate reference docs for the new features you've added.

@shiiinji
Copy link
Contributor Author

One more change - can you please run yarn docs at the root of the repository? That will auto-generate reference docs for the new features you've added.

I run yarn docs and commited the auto-generate reference docs by #d000464.

@jhuleatt jhuleatt merged commit b6c8eeb into FirebaseExtended:main Aug 26, 2021
@jhuleatt
Copy link
Collaborator

Thanks again @shiiinji! These changes are available now with

npm install reactfire@exp

# OR

yarn add reactfire@exp

And will be included in an upcoming release!

@shiiinji
Copy link
Contributor Author

Thank your great feedbacks.

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants