[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move build from TSDX to Vite #534

Merged
merged 8 commits into from
Aug 10, 2022
Merged

Move build from TSDX to Vite #534

merged 8 commits into from
Aug 10, 2022

Conversation

jhuleatt
Copy link
Collaborator
@jhuleatt jhuleatt commented Aug 3, 2022 •
edited
Loading
  • Pulls out TSDX, replaces with Vite
  • Updates dependencies
  • Moves from yarn to npm now that we don't need yarn workspaces
  • Uses Vitest instead of Jest
  • Updates Firebase CLI to v11, which requires removing Node 12 from our tests since the CLI requires Node 14+
  • Running the build locally creates a stats.html file. Open that in the browser to inspect the built bundle

@jhuleatt
Copy link
Collaborator Author
jhuleatt commented Aug 4, 2022 •
edited
Loading

I'm not sure why the Storage tests keep timing out only on Node 14. I can run them locally in Node 14 with no issue.

@jhuleatt jhuleatt merged commit f6d2351 into main Aug 10, 2022
@jhuleatt jhuleatt deleted the tsdx-to-vite branch August 10, 2022 20:01
@jhuleatt jhuleatt mentioned this pull request Aug 17, 2022
Open
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhuleatt @jamesdaniels