[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not serializable arguments when calling environment feature version webhooks #4187

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: not serializable arguments when calling environment feature version webhooks #4187

merged 1 commit into from
Jun 19, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes an issue with non-serializable arguments passed to the call_environment_webhooks function.

How did you test this code?

Updated the existing unit test.

@vercel Vercel
Copy link
vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 19, 2024 7:42am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 19, 2024 7:42am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 19, 2024 7:42am

@github-actions github-actions bot added fix api Issue related to the REST API and removed fix labels Jun 19, 2024
@matthewelwell matthewelwell requested review from a team and novakzaballa and removed request for a team June 19, 2024 07:43
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 19, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-53201

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4187

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@codecov Codecov
Copy link
codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (17782bd) to head (20a01e8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4187   +/-   ##
=======================================
  Coverage   96.50%   96.51%           
=======================================
  Files        1177     1177           
  Lines       38215    38230   +15     
=======================================
+ Hits        36881    36896   +15     
  Misses       1334     1334

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 319708c Jun 19, 2024
25 checks passed
@matthewelwell matthewelwell deleted the fix/call-versioning-webhooks-inputs branch June 19, 2024 08:26
@dabeeeenster dabeeeenster mentioned this pull request Jun 19, 2024
Merged
@matthewelwell matthewelwell mentioned this pull request Jun 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees
No one assigned
Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewelwell @khvn26