gpflow.Module.parameter (base for Model) returns an tuple, not generator #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter` to be wrapped in a tuple, not generators This matches tf2 behaviour [here](https://github.com/tensorflow/tensorflow/blob/1cf0898dd4331baf93fe77205550f2c2e6c90ee5/tensorflow/python/module/module.py#L143) and prevents accidentally trying to reuse the same the generator once exhausted.
Codecov Report
@@ Coverage Diff @@
## develop-2.0 #1102 +/- ##
==============================================
+ Coverage 95.97% 96% +0.03%
==============================================
Files 64 64
Lines 2807 2807
==============================================
+ Hits 2694 2695 +1
+ Misses 113 112 -1
Continue to review full report at Codecov.
|
st--
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes PR #1100
The variables and trainable_variables parameters on tf.Module return tuples: see here However, the key problem here is that at the moment the
Modulewrapper we have neither returns lists nor tuples, but rather a generator forself._flatten. If you don't wrap the generator in an iterable, when you pass the generator to the frozenset SampleHelper, the generator exhausts after its first use. eg:I was unsure where to put the tests, so I put them in printing.