fix: address corner cases in filename sanitization #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
直接将总结的对话标题作为文件名保存存在不妥，我看了一下保存的对话json文件，其中包含一些对话元信息，是否可以考虑将标题存于元信息中，使用标题hash或保存时间戳等作为文件名？ |
|
确实，用hash作为文件名会更好。 |
Closed
Keldos-Li
approved these changes
Mar 30, 2024
bentwnghk
added a commit
to bentwnghk/CHChatGPT
that referenced
this pull request
Apr 3, 2024
fix: address corner cases in filename sanitization (GaiZhenbiao#1070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
作者自述
描述
部分模型在总结对话草拟标题时可能无法很好的遵循指令，生成的标题会导致历史文件无法正常保存。
本次 pull request 主要对文件名中特殊字符的处理进行了优化，确保文件名在保存时不会因为特殊字符而导致系统错误。
Before:
After:
相关问题
#913
补充信息
关于对话标题保存相关建议见评论区。