fix test

GoogleChrome · Aug 9, 2023 · 4210ece · 4210ece
1 parent 86b9602
commit 4210ece
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/lib/dependency-graph/simulator/network-analyzer.js b/core/lib/dependency-graph/simulator/network-analyzer.js
@@ -515,6 +515,7 @@ class NetworkAnalyzer {
     // equalWithExcludedFragments is expensive, so check that the resourceUrl starts with the request url first
     const matchingRequests = records.filter(request =>
       request.resourceType === 'Document' &&
+      // Note: `request.url` should never have a fragment, else this optimization gives wrong results.
       resourceUrl.startsWith(request.url) &&
       UrlUtils.equalWithExcludedFragments(request.url, resourceUrl)
     );

diff --git a/core/test/computed/main-resource-test.js b/core/test/computed/main-resource-test.js
@@ -76,7 +76,7 @@ describe('MainResource computed artifact', () => {
     const networkRecords = [
       {url: 'https://example.com'},
       {url: 'https://example.com/sw.js'},
-      {url: 'https://example.com#pickme'},
+      {url: 'https://example.com', resourceType: 'Document', failed: true},
     ];
 
     const URL = {mainDocumentUrl: 'https://example.com'};
@@ -85,7 +85,8 @@ describe('MainResource computed artifact', () => {
 
     const context = {computedCache: new Map()};
     return MainResource.request(artifacts, context).then(output => {
-      assert.equal(output.url, 'https://example.com#pickme');
+      assert.equal(output.url, 'https://example.com');
+      assert.equal(output.failed, true);
     });
   });
 });