[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy the updated report to the web after every push #8159

Closed
paulirish opened this issue Apr 10, 2019 · 4 comments
Closed

Deploy the updated report to the web after every push #8159

paulirish opened this issue Apr 10, 2019 · 4 comments
Labels
needs-priority

Comments

@paulirish
Copy link
Member

We have a bunch of report UI changes upcoming.. the first of which from @hoten updates the gauges (#8121).

Zeit/now.sh has an integration with GitHub nowadays that makes this very straightforward. (Last year, I had a real hacky solution for this, which is no longer necessary yay!)

Please check it out in action here: https://github.com/paulirish/test-lh-for-now/pull/3

  • It'll create new deployment items and create a commit status entry (or two) to communicate status of the deployment:
    image
  • Click on View Deployment and you'll be brought to something like https://test-lh-for-now-8viv2go5c.now.sh/

These live forever and are free. The report deployment is usually up in ~30s after the commit push.

Considerations:

  1. We can't block the deployment from starting. So we can't really say "only do this on report-affecting PRs". The best we could do is fail a deployment because we don't want it to finish.
  2. The GoogleChrome org needs to approve the Now github application.

I think this would be super helpful for review of upcoming report redesign PRs. We could also incorporate stackpacks or plugins if we wanted to always see those too.

What do folks think? Good stuff or annoying?
@patrickhulce
Copy link
Collaborator
patrickhulce commented Apr 10, 2019 •
edited
Loading

it's dope and super necessary IMO as we work on total report redesign!

EDIT: we can generate from the artifacts too to see audit result changes :)

@paulirish
Copy link
Member Author
paulirish commented Apr 10, 2019 •
edited
Loading

@addyosmani can you help us enable the Now github app for this org?
I think this is the url: https://github.com/organizations/GoogleChrome/settings/installations

update: this is enabled now.

This was referenced Apr 11, 2019
Merged
Merged
@paulirish
Copy link
Member Author
paulirish commented Apr 11, 2019 •
edited by connorjclark
Loading

Feature requests:

  • PSI UI
  • devtools UI
  • Other reports with different states..
    • cnn, lots-of-errors.html, plugin

@brendankenny brendankenny mentioned this issue Apr 19, 2019
Merged
@connorjclark
Copy link
Collaborator

now is now now

I think we can close this. improving what we put on now will be an ongoing endeavor, hopefully. (like #10151)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @patrickhulce @connorjclark