build: stage viewer with now-build #10151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow. the index page links to https://lighthouse-52bt5b3pt.now.sh/viewer which doesn't work. but https://lighthouse-52bt5b3pt.now.sh/viewer/ does. |
I think that's on us for the relative links, no? We should just have viewer canonicalize/redirect it's URL if it doesn't end in |
patrickhulce
approved these changes
Dec 29, 2019
|
was given a workaround for the now issue. works now |
|
sweet 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful for demoing changes such as #10148. Also, if one of the now reports doesn't showcase what a PR is changing, we could use the viewer to load a better-suited report.