[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: link to updated scoring documentation #10725

Merged
merged 4 commits into from
May 8, 2020

Conversation

paulirish
Copy link
Member
@paulirish paulirish commented May 7, 2020

linking up the web.dev scoring docs.

also small wording tweak:

Values are estimated and may vary. The performance score is [based only on these metrics]

to

Values are estimated and may vary. The [performance score is calculated] directly from these metrics.

useless screenshot
image

@paulirish paulirish requested a review from a team as a code owner May 7, 2020 20:54
@paulirish paulirish requested review from connorjclark and removed request for a team May 7, 2020 20:54
@paulirish
Copy link
Member Author
paulirish commented May 7, 2020

@connorjclark you wanted to link up the scorecalc too..

image

Hmmm. we could start with adding " [See calculator]" on the end of that sentence. We could improve on that later, I'll file an issue for that. EDIT: filed #10726

@paulirish paulirish added the 6.0 label May 7, 2020
Copy link
Collaborator
@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but unit tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants