core(offscreen-images): pass images with 'loading' attribute #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazyan
commented
Dec 16, 2019
jazyan
commented
Dec 16, 2019
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
connorjclark
requested changes
Dec 16, 2019
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
this is looking great @jazyan thanks so much for helping out with this!
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
exterkamp
approved these changes
Dec 18, 2019
connorjclark
approved these changes
Dec 19, 2019
| devtoolsLogs: {}, | ||
| }; | ||
|
|
||
| return UnusedImages.audit_(artifacts, networkRecords, context).then(auditResult => { |
There was a problem hiding this comment.
bit iffy on the .then in an async function, but all these other tests do the same so 🤷♂️
|
Thanks for the reviews! Merging is blocked for me, so if all looks good, would appreciate if an authorized user can merge this 😅 |
|
🎉 |
|
woohoo, great contribution @jazyan! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Native lazy-loading was recently introduced in Chrome 76. This PR excludes images with a specified 'loading' attribute ('lazy' and 'eager', 'auto' TBD) from the 'defer offscreen images' check.
See https://web.dev/native-lazy-loading/ for more details about the loading attribute.
Related Issues/PRs
fixes: #10053