clients(extension): firefox #10332
clients(extension): firefox #10332
Conversation
|
cc @digitarald |
| await Promise.all([ | ||
| buildEntryPoint(), | ||
| copyAssets(), | ||
| ]); | ||
|
|
There was a problem hiding this comment.
this is simpler to use. just always package.
|
This is amazing Connor, thanks for working on it. Let me know if you find any blockers that I can help with.
You can use Toggle Disable Popup Auto-Hide in the Browser Toolbox, but macOS screenshots usually work fine for me. |
|
Thanks @digitarald ! |
| @@ -140,7 +140,7 @@ npm publish | |||
| # Publish viewer. | |||
| yarn deploy-viewer | |||
|
|
|||
| # Publish the extension (if it changed). | |||
| # Publish the extensions (if it changed). | |||
There was a problem hiding this comment.
Are there firefox specific instructions so that someone can release this? Or will that be handled in a follow up once this has landed and can be released for the first time?
There was a problem hiding this comment.
I haven't uploaded to the FF store before, so IDK. I'll update when I do.
| @@ -120,7 +124,7 @@ function getSiteUrl() { | |||
|
|
|||
| const url = new URL(tabs[0].url); | |||
| if (url.hostname === 'localhost') { | |||
| reject(new Error('Use DevTools to audit pages on localhost.')); | |||
| reject(new Error(STRINGS.localhostErrorMessage)); | |||
| } else if (/^(chrome|about)/.test(url.protocol)) { | |||
There was a problem hiding this comment.
Any firefox specific urls we need to include here now? firefox://page?
There was a problem hiding this comment.
just abouts i think
about:about
| const BROWSER_BRAND = '___BROWSER_BRAND___'; | ||
|
|
||
| const CHROME_STRINGS = { | ||
| localhostErrorMessage: 'Use DevTools to audit pages on localhost.', |
There was a problem hiding this comment.
In the future, if we want to support i18n pulling these out to /locales/ (and the other user facing strings) would be good. But this is fine for now since we don't need to i18n them.
| @@ -120,7 +133,7 @@ function getSiteUrl() { | |||
|
|
|||
| const url = new URL(tabs[0].url); | |||
| if (url.hostname === 'localhost') { | |||
| reject(new Error('Use DevTools to audit pages on localhost.')); | |||
| reject(new Error(STRINGS.localhostErrorMessage)); | |||
| } else if (/^(chrome|about)/.test(url.protocol)) { | |||
| reject(new Error(`Cannot audit ${url.protocol}// pages.`)); | |||
There was a problem hiding this comment.
In聽Firefox, about:聽protocol聽pages don鈥檛聽currently include聽the聽//.
|
You聽might聽want to聽put "fixes #6032" into聽the聽PR聽description. |
|
We're going to keep that issue open, because it's tracking real Firefox support (as in, protocol-level). We have no plans to do that, though, atm. The extension is offered as a way to quickly generate report for the (public) url you are looking at, so at least FF users will have that. |
Just needed to replace some strings that only make sense in Chrome.
I'd share pictures, but I am having trouble keeping the Firefox extension open while take screengrabs.
(this is funny - the popup from the Firefox extension sticks around even when I go back to Chrome :) neat hidden "picture in picture" feature, across ~~~~~browsers 馃帀 )