[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: eslintignore .d.ts files #11793

Merged
merged 1 commit into from
Dec 9, 2020
Merged

misc: eslintignore .d.ts files #11793

merged 1 commit into from
Dec 9, 2020

Conversation

brendankenny
Copy link
Member
@brendankenny brendankenny commented Dec 9, 2020

this will silence all the complaining in vscode. I can't figure out a nice way to actually turn the errors there into usable errors in yarn lint. Probably need to dig deeper into @typescript-eslint/eslint-plugin.

The alternative to completely ignoring is selectively turning off rules, as some of the remaining rules could be improvements (even if not enforced by our tests). Something like this in .eslintrc.js:

{
  files: ['*.d.ts'],
  rules: {
    'strict': 0,
    'no-unused-vars': 0,
    'no-undef': 0,
    'max-len': 0,
  },
},

@brendankenny brendankenny requested a review from a team as a code owner December 9, 2020 04:19
@brendankenny brendankenny requested review from patrickhulce and removed request for a team December 9, 2020 04:19
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huzzah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants