[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): fix logging in programmatic use code example #11116

Merged
merged 1 commit into from
Jul 17, 2020
Merged

docs(readme): fix logging in programmatic use code example #11116

merged 1 commit into from
Jul 17, 2020

Conversation

staceytay
Copy link
Contributor

Summary

This PR fixes the issue in #11106 where the current programmatic use example in readme.md doesn't actually show log output. It also updates the description and code in the "Turn on logging" section.

Related Issues/PRs

#11106

@staceytay staceytay requested a review from a team as a code owner July 17, 2020 11:11
@staceytay staceytay requested review from Beytoven and removed request for a team July 17, 2020 11:11
patrickhulce
patrickhulce approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @staceytay! :) 🎉

@patrickhulce patrickhulce merged commit 488c7ba into GoogleChrome:master Jul 17, 2020
@staceytay
Copy link
Contributor Author

thanks @patrickhulce ! :)

@staceytay staceytay mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@Beytoven Beytoven Awaiting requested review from Beytoven

Assignees

@Beytoven Beytoven

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@staceytay @patrickhulce @googlebot @devtools-bot @Beytoven