[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): extract gotoURL to navigation module #12421

Merged
merged 7 commits into from
May 4, 2021
Merged

core(driver): extract gotoURL to navigation module #12421

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45d489e
core(driver): extract gotoURL to navigation module
patrickhulce Apr 28, 2021
ef8b8d5
more unit fixes
patrickhulce Apr 28, 2021
3c65557
Update lighthouse-core/gather/driver.js
patrickhulce Apr 29, 2021
cb21a19
Update lighthouse-core/gather/driver/navigation.js
patrickhulce Apr 29, 2021
fcc6d8b
Merge branch 'master' into fr_navigation_refactor
patrickhulce May 3, 2021
e0e6989
fix extra mock methods in driver-test
patrickhulce May 3, 2021
3d5899f
fix protocol.d.ts issues
patrickhulce May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix extra mock methods in driver-test
  • Loading branch information
@patrickhulce
patrickhulce committed May 3, 2021
commit e0e69892b185631fad4048ca9f559d3edf2d3c6d
3 changes: 0 additions & 3 deletions lighthouse-core/test/gather/driver-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jest.useFakeTimers();
* @typedef DriverMockMethods
* @property {Driver['evaluate']} evaluate redefined to remove "private" designation
* @property {Driver['evaluateAsync']} evaluateAsync redefined to remove "private" designation
* @property {ReturnType<typeof createMockOnceFn>} on
* @property {ReturnType<typeof createMockOnceFn>} once
* @property {(...args: RecursivePartial<Parameters<Driver['gotoURL']>>) => ReturnType<Driver['gotoURL']>} gotoURL
*/

/** @typedef {Omit<Driver, keyof DriverMockMethods> & DriverMockMethods} TestDriver */
Expand Down