[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(treemap): i18n #12441

Merged
merged 20 commits into from
May 14, 2021
Merged

misc(treemap): i18n #12441

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
51bae87
wip
connorjclark Apr 30, 2021
7ff5861
update
connorjclark May 4, 2021
3ca66c4
Merge remote-tracking branch 'origin/master' into treemap-i18n
connorjclark May 4, 2021
c06b918
update
connorjclark May 5, 2021
139bcaa
Merge remote-tracking branch 'origin/master' into treemap-i18n
connorjclark May 7, 2021
cba6faa
wip
connorjclark May 8, 2021
e8dbc07
no Util
connorjclark May 10, 2021
36e0838
fix
connorjclark May 10, 2021
576f374
tweak
connorjclark May 10, 2021
4b0b721
update
connorjclark May 11, 2021
12b1ba8
fixtest
connorjclark May 11, 2021
e150536
tweak
connorjclark May 11, 2021
b76273f
Merge remote-tracking branch 'origin/master' into treemap-i18n
connorjclark May 11, 2021
78f168c
comment
connorjclark May 11, 2021
a97202d
Apply suggestions from code review
connorjclark May 11, 2021
44a203f
pr
connorjclark May 11, 2021
eddd1af
updatestrings
connorjclark May 11, 2021
9a7f0f8
lol
connorjclark May 11, 2021
cdc698e
strings
connorjclark May 14, 2021
6f9e53c
comment
connorjclark May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lol
  • Loading branch information
@connorjclark
connorjclark committed May 11, 2021
commit 9a7f0f8914abc06fbc0eb815dc43c23d08a41247
4 changes: 2 additions & 2 deletions lighthouse-treemap/app/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ class TreemapViewer {

return {
id: 'duplicate-modules',
label: TreemapUtil.i18n.strings.duplicateModules,
label: TreemapUtil.i18n.strings.duplicateModulesLabel,
subLabel: enabled ? TreemapUtil.i18n.formatBytesWithBestUnit(potentialByteSavings) : 'N/A',
highlights,
enabled,
Expand All @@ -294,7 +294,7 @@ class TreemapViewer {

viewModes.push({
id: 'all',
label: TreemapUtil.i18n.strings.all,
label: TreemapUtil.i18n.strings.allLabel,
subLabel: TreemapUtil.i18n.formatBytesWithBestUnit(this.currentTreemapRoot.resourceBytes),
enabled: true,
});
Expand Down