[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(fr): convert image-elements gatherer #12474

Merged
merged 17 commits into from
May 17, 2021
Merged

core(fr): convert image-elements gatherer #12474

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1494ebb
core(fr): convert image-elements gatherer
adamraine May 13, 2021
80af0f0
add to config
adamraine May 13, 2021
04d4911
Update lighthouse-core/test/gather/gatherers/image-elements-test.js
adamraine May 13, 2021
947a260
Update lighthouse-core/test/gather/gatherers/image-elements-test.js
adamraine May 13, 2021
5db0fbd
mutiple source rules
adamraine May 13, 2021
9168e6d
update expectation
adamraine May 13, 2021
cc5ca13
no optional params
adamraine May 13, 2021
85cce15
spy on
adamraine May 13, 2021
c4d7480
fetchSourceRules test
adamraine May 13, 2021
3d8c71c
more tests
adamraine May 13, 2021
f3ef859
lint
adamraine May 13, 2021
b6a0388
config test
adamraine May 13, 2021
1fe02b4
sometimes my genius is almost frightening
adamraine May 14, 2021
2f01f63
stricter tests
adamraine May 14, 2021
c4c39c0
cleanup
adamraine May 14, 2021
2ba7a68
typo
adamraine May 14, 2021
d91e945
comments
adamraine May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
config test
  • Loading branch information
@adamraine
adamraine committed May 13, 2021
commit b6a03881bf23b235c26e2bfebe4d4a305e155b0d
4 changes: 2 additions & 2 deletions lighthouse-core/test/fraggle-rock/config/config-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ describe('Fraggle Rock Config', () => {
});

it('should throw on invalid artifact definitions', () => {
const configJson = {artifacts: [{id: 'ImageElements', gatherer: 'image-elements'}]};
expect(() => initializeConfig(configJson, {gatherMode})).toThrow(/ImageElements gatherer/);
const configJson = {artifacts: [{id: 'FullPageScreenshot', gatherer: 'full-page-screenshot'}]};
expect(() => initializeConfig(configJson, {gatherMode})).toThrow(/FullPageScreenshot gatherer/);
});

it('should resolve navigation definitions', () => {
Expand Down