[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(timespan-runner): warn if a navigation is detected #15407

Merged
merged 3 commits into from
Aug 28, 2023
Merged

core(timespan-runner): warn if a navigation is detected #15407

merged 3 commits into from
Aug 28, 2023

Conversation

adamraine
Copy link
Member

Part of #14775

@adamraine adamraine requested a review from a team as a code owner August 25, 2023 00:31
@adamraine adamraine requested review from brendankenny and removed request for a team August 25, 2023 00:31
adamraine
adamraine commented Aug 25, 2023
View reviewed changes
core/test/scenarios/pptr-test-utils.js
@@ -77,7 +77,6 @@ function createTestState() {

beforeEach(async () => {
trace = undefined;
console.log('########');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 😬 😬 😬 😬 😬 😬 😬

@adamraine adamraine merged commit 29b80e5 into main Aug 28, 2023
29 checks passed
@adamraine adamraine deleted the no-nav-in-timespan branch August 28, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamraine @connorjclark @brendankenny @devtools-bot