tests: better error handling when test modules fail to load #15421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Aug 29, 2023
| for (const test of tests) { | ||
| try { | ||
| mocha.files = [test]; | ||
| await mocha.loadFilesAsync(); |
There was a problem hiding this comment.
Can't just await import because mocha does some non trivial logic for importing + setting up mocha globals.
adamraine
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current test runner gives no information in the summary at the end if some test file fails to be imported, meaning you have to hunt a huge output of tests to find what file failed to load.
Now the test runner first tries to import each test file, and tracks which ones fail to load.