core: add TBT savings to bootup-time
#15431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Aug 31, 2023
|
|
||
| try { | ||
| const metricComputationData = Audit.makeMetricComputationDataInput(artifacts, context); | ||
| const tasks = await TBTImpactTasks.request(metricComputationData, context); |
There was a problem hiding this comment.
In theory it would be better to compute these tasks once and use them for normal procedure on this audit. Unfortunately this would break one of our test cases which asserts this audit get's no data for a bad trace.
I'm open to changing that logic, it means this audit would error whenever TBT errors which seems reasonable to me. It didn't seem important enough just to make the code neater IMO.
bootup-time
connorjclark
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to DOM size this computes TBT impact based on the subset of main tasks with relevant group ids.