[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: do not double report artifact dep error to sentry #15777

Merged
merged 1 commit into from
Jan 26, 2024
Merged

misc: do not double report artifact dep error to sentry #15777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/gather/runner-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
* @param {Error} error
*/
function createDependencyError(dependency, error) {
return new Error(`Dependency "${dependency.id}" failed with exception: ${error.message}`);
const err = new Error(`Dependency "${dependency.id}" failed with exception: ${error.message}`);
// @ts-expect-error - We already reported the original error to Sentry, don't do it again.
err.expected = true;
return err;

Check warning on line 39 in core/gather/runner-helpers.js

View check run for this annotation

Codecov / codecov/patch

core/gather/runner-helpers.js#L36-L39 

Added lines #L36 - L39 were not covered by tests
}

/** @return {ArtifactState} */
Expand Down
Loading