[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(entity-classification): classify chrome extensions into separate entities #15017

Merged
merged 14 commits into from
May 16, 2023
Merged

core(entity-classification): classify chrome extensions into separate entities #15017

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dfb949c
core(entity-classification): classify chrome extensions into its own …
alexnj Apr 25, 2023
2671ab8
add tests
alexnj Apr 25, 2023
3796d7a
Merge branch 'main' into chrome-extensions-classification
alexnj Apr 25, 2023
10cf5a6
Review changes
alexnj Apr 26, 2023
98615d3
Upgrade to Level 2 classification - resolve each extension to their e…
alexnj Apr 26, 2023
ed16c1d
Merge remote-tracking branch 'origin/main' into chrome-extensions-cla…
alexnj Apr 26, 2023
40d8880
Merge remote-tracking branch 'origin/main' into chrome-extensions-cla…
alexnj May 2, 2023
0661062
Recognize unknown chrome extensions + refactor.
alexnj May 4, 2023
8f97e1b
Merge remote-tracking branch 'origin/main' into chrome-extensions-cla…
alexnj May 4, 2023
dbd9600
fix some typos + comment for the node url parser spec difference
alexnj May 4, 2023
aef3345
Merge branch 'main' into chrome-extensions-classification
alexnj May 9, 2023
f366795
private fn name changes
alexnj May 9, 2023
15f7fc7
fn name
alexnj May 9, 2023
3b44036
Merge branch 'main' into chrome-extensions-classification
alexnj May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fn name
  • Loading branch information
@alexnj
alexnj committed May 9, 2023
commit 15f7fc728b985a41c6889d32ff943f86881b7dd7
6 changes: 3 additions & 3 deletions core/computed/entity-classification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ class EntityClassification {
/**
* @param {EntityCache} entityCache
* @param {string} url
* @param {string=} optionalName
* @param {string=} extensionName
* @return {LH.Artifacts.Entity}
*/
static makeupChromeExtensionEntity_(entityCache, url, optionalName) {
static makeupChromeExtensionEntity_(entityCache, url, extensionName) {
const origin = Util.getChromeExtensionOrigin(url);
const host = new URL(origin).host;
const name = optionalName || host;
const name = extensionName || host;

const cachedEntity = entityCache.get(origin);
if (cachedEntity) return cachedEntity;
Expand Down
Loading