core: add guidance level to performance audits #15025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we take some group votes on difficulty again? remember this? |
I'm hoping a switch to guidance would make things a little less subjective. I'm fine with making a spreadsheet to organize this and facilitate discussion, but I don't want to compute an "average" guidance level based on our individual rankings. Edit: added a guidance level sheet to facilitate discussion |
connorjclark
approved these changes
Aug 29, 2023
alexnj
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexnj and I discussed changing our "difficulty" level to a "guidance" level since difficulty can be very page dependent, but we know how much guidance our audit is going to provide. These are the guidance level descriptions I used for this PR:
3: We give you specifics on what to fix and we tell you how to fix it2: We give you specifics on what to fix but you will need to design a solution yourself1: No specifics just a general overview, design a solution yourselfIn the future, we could consider adding a
0level for things like manual audits or evenuser-timings, but I don't see it being useful right now. These guidance levels could also be applied to non-performance audits.All of these are up for discussion, this was my initial pass.We discussed, these values are now the best consensus so far.