[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_audit: td-has-header #15051

Merged
merged 27 commits into from
May 12, 2023
Merged

new_audit: td-has-header #15051

merged 27 commits into from
May 12, 2023

Conversation

jazyan
Copy link
Collaborator
@jazyan jazyan commented May 5, 2023

See http://go/prcpg for the current list of audits to be enabled.

Surprisingly, a11y_tester.html already has a specific test case for this.

@jazyan jazyan requested a review from a team as a code owner May 5, 2023 19:36
@jazyan jazyan requested review from brendankenny and removed request for a team May 5, 2023 19:36
@connorjclark
Copy link
Collaborator
connorjclark commented May 5, 2023 •
edited
Loading

This audit has some funny history.

#1768 added the test case.

#6169 is when Paul noticed we never even had an audit for it.

@connorjclark
Copy link
Collaborator

Can you fill out the expected audit result for td-has-header in cli/test/smokehouse/test-definitions/a11y.js? Ran via yarn smoke a11y

@connorjclark connorjclark changed the title core(a11y): add audit td-has-header new_audit: td-has-header May 5, 2023
@paulirish
Copy link
Member

fwiw This is the test failure I'm seeing in the CI logs:
image

@jazyan
Copy link
Collaborator Author
jazyan commented May 9, 2023

Added td-has-header case to a11y smoke tests, and updated the category renderer unit test.

Looking into the DevTools e2e failing assertions 👀

(and whoops, accidentally re-added commits after fetch from main.)

brendankenny
brendankenny approved these changes May 12, 2023
View reviewed changes
Copy link
Member
@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some potential UIStrings suggestions but otherwise LGTM!

core/audits/accessibility/td-has-header.js Outdated Show resolved Hide resolved
core/audits/accessibility/td-has-header.js Outdated Show resolved Hide resolved
core/audits/accessibility/td-has-header.js Outdated Show resolved Hide resolved
@jazyan @brendankenny
apply UI string review suggestions
c880d34 
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
@jazyan jazyan merged commit 177af65 into main May 12, 2023
31 checks passed
@jazyan jazyan deleted the a11y branch May 12, 2023 18:12
@connorjclark connorjclark mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jazyan @connorjclark @paulirish @brendankenny @devtools-bot