[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add cjs path for logger #15084

Merged
merged 6 commits into from
May 16, 2023
Merged

misc: add cjs path for logger #15084

merged 6 commits into from
May 16, 2023

Conversation

adamraine
Copy link
Member
@adamraine adamraine commented May 16, 2023 •
edited
Loading

We need to do a patch release to restore cjs since the update today broke some folks downstream.

I packaged this logger and verified that chrome launcher passed all it's tests with it.

@adamraine adamraine requested a review from a team as a code owner May 16, 2023 21:53
@adamraine adamraine requested review from connorjclark and removed request for a team May 16, 2023 21:53
connorjclark
connorjclark reviewed May 16, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@brendankenny
Copy link
Member

Does this mean there will be two versions used in a typical LH run?

@derek derek mentioned this pull request May 16, 2023
Closed
@adamraine
Copy link
Member Author

Does this mean there will be two versions used in a typical LH run?

That may have already been the case w/ chrome launcher requesting version 1.0.0 and lighthouse requesting version 1.3.0 (soon to be 1.4.1)

@brendankenny
Copy link
Member
brendankenny commented May 16, 2023 •
edited
Loading

That may have already been the case w/ chrome launcher requesting version 1.0.0 and lighthouse requesting version 1.3.0 (soon to be 1.4.1)

Sure, but that's always the case. chrome-launcher is requesting ^1.0.0 which is compatible with the ^1.4.1 added in #15082, so if yarn didn't suck with was more aggressive with coalescing updates that PR would still have a single version like it does today. This PR adds two versions even if lighthouse-logger is resolved to a single package.

It would be good to have a path out of this situation (e.g. update chrome-launcher) for after this fix lands.

@adamraine adamraine merged commit b0a9217 into main May 16, 2023
31 checks passed
@adamraine adamraine deleted the logger-cjs branch May 16, 2023 22:59
@connorjclark
Copy link
Collaborator
connorjclark commented May 16, 2023 •
edited
Loading

All the state is stored in marky and debug, nothing in Logger, so at the very least the behavior of two separate instances is the same as if there were only one.

@brendankenny
Copy link
Member

All the state is stored in marky and debug, nothing in Logger

Today it is!

We control all the pieces here, so there's no reason we can't make it simple again now that the shipping version is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamraine @brendankenny @connorjclark