-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: update error icons #15092
report: update error icons #15092
Conversation
…runtime-error-icon
…runtime-error-icon
@adamraine Thanks for the review! I've updated the svg definitions and now there is only one definition in CSS. I did some tinkering and found a way to get the positioning right using only background-images. I think the icon being off center in the audit list was partly due to the svg definition I originally had, it should be updated now and appear vertically centered in the row on Chrome (Version 113.0.5672.126) and Firefox (109.0.1). Let me know if it still appears off and I'll try to reproduce the alignment issue to fix it. |
…runtime-error-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I made some changes to scale up the svg to fit it's view box, then scale it down by 50% when it's in a score gauge. This allows us to inherit a lot of the same CSS used to render the normal score icons in audits and metrics.
Awesome! I just checked out your changes and everything looks great. That was a smart idea to scale the svg to allow for us to inherit a lot of the same CSS. |
Summary
Fixes #9820
Updates runtime error icons to use the SVGs provided in #9820 (comment)
Testing
yarn build-sample-reports
Related Issues/PRs
#9272
#9968 (comment)