core(network-requests): add entity classification #15105
Conversation
isFirstParty && isThirdParty to network-requests auditisFirstParty && isThirdParty to network-requests audit
isFirstParty && isThirdParty to network-requests auditisFirstParty & isThirdParty to audit
core/audits/network-requests.js
Outdated
| const mainResource = await MainResource.request({devtoolsLog, URL: artifacts.URL}, context); | ||
| if (artifacts.GatherContext.gatherMode === "navigation") { | ||
| const mainResource = await MainResource.request( | ||
| { devtoolsLog, URL: artifacts.URL }, |
There was a problem hiding this comment.
this and the change above look like they may be default prettier formatting or something?
There was a problem hiding this comment.
yep. it was. do y'all have formatter settings that can be applied to VSCode? (I could add to the contributing guide if there is)
isFirstParty & isThirdParty to auditentity to audit
|
@brendankenny PTAL when you get the chance. Is there anything I've missed here? |
core/audits/network-requests.js
Outdated
| @@ -77,6 +83,7 @@ class NetworkRequests extends Audit { | |||
| priority: record.priority, | |||
| isLinkPreload, | |||
| experimentalFromMainFrame, | |||
| entityName, | |||
There was a problem hiding this comment.
We could name this as entity to match the pattern of audit-side classification. Third-party summary audit is a good example.
When the entity property is provided from an audit, the report rendering side skips classification and relies on the provided one. See report-side classification yielding to audit provided entity.
In this case the audit isn't rendered, but would be good to keep the same convention.
There was a problem hiding this comment.
Thanks for review @alexnj. PTAL 🙏
|
@adamraine I think this is ready to go 👍 |
entity to audit
Summary
At present it's difficult to collect which requests are first and third party in LH. As of this PR,
entitywill be present in thenetwork-requestsaudit output.Related Issues/PRs
requestCounttothird-party-summarysubitem attributes #15093