tests(smoke): add expectation for lcp-element #15112

connorjclark · 2023-05-24T21:50:07Z

Smokerider did not catch the error from #15075 because we have no smoke tests that check largest-contentful-paint-element with simulated throttling.

adamraine · 2023-05-24T21:54:41Z

Wouldn't the TTFB error be caught here:

lighthouse/cli/test/smokehouse/test-definitions/dobetterweb.js

Lines 588 to 597 in 469157a

    
             'metrics': { 
        
               // Flaky in DevTools 
        
               _excludeRunner: 'devtools', 
        
               details: {items: {0: { 
        
                 timeToFirstByte: '450+/-100', 
        
                 lcpLoadStart: '7750+/-500', 
        
                 lcpLoadEnd: '7750+/-500', 
        
               }}}, 
        
             }, 
        
           },

connorjclark · 2023-05-24T22:08:36Z

yeah. also tho we aren't running dbw in smokerider yet, until #15111

won't hurt to also add a check for lcp element audit

tests(smoke): add expectation for lcp-element

f7fc1d6

connorjclark requested a review from a team as a code owner May 24, 2023 21:50

connorjclark requested review from brendankenny and removed request for a team May 24, 2023 21:50

adamraine approved these changes May 24, 2023

View reviewed changes

connorjclark added the land-when-ci-is-green label May 24, 2023

devtools-bot assigned brendankenny May 24, 2023

devtools-bot added the waiting4reviewer label May 24, 2023

adamraine removed the land-when-ci-is-green label May 24, 2023

connorjclark merged commit c68431a into main May 24, 2023
33 checks passed

connorjclark deleted the dbw-lcp-element branch May 24, 2023 22:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests(smoke): add expectation for lcp-element #15112

tests(smoke): add expectation for lcp-element #15112

tests(smoke): add expectation for lcp-element #15112

tests(smoke): add expectation for lcp-element #15112

Conversation