[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): add package name #15116

Merged
merged 1 commit into from
May 26, 2023
Merged

misc(proto): add package name #15116

merged 1 commit into from
May 26, 2023

Conversation

derekperkins
Copy link
Contributor
@derekperkins derekperkins commented May 25, 2023 •
edited
Loading

I picked a package name that seemed reasonable, open to suggestions if there are any preferences
Fixes #15115

@derekperkins derekperkins requested a review from a team as a code owner May 25, 2023 22:27
@derekperkins derekperkins requested review from connorjclark and removed request for a team May 25, 2023 22:27
@derekperkins derekperkins mentioned this pull request May 25, 2023
Closed
connorjclark
connorjclark approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator
@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suspect anyone but us actually uses the proto definition (if you are, please drop us a line as we are just curious!). But yeah this package name is good for us, thanks for the PR!

@connorjclark connorjclark merged commit e7a6d39 into GoogleChrome:main May 26, 2023
33 checks passed
@derekperkins
Copy link
Contributor Author

We're starting to use the proto for long term storage of Lighthouse results. Not sure if there's other usage, but it makes it so much easier to work in other languages outside js without having to define and manage our own types

@derekperkins derekperkins deleted the patch-1 branch May 26, 2023 20:41
@unmultimedio
Copy link

Hello @connorjclark! two small questions:

  • Would it be possible to move the file into a directory that matches the package name, with a valid version? I'm interested in mainly these 2 suggestions: PACKAGE_DIRECTORY_MATCH and PACKAGE_VERSION_SUFFIX.
  • When could we expect a new stable semver release that includes this change? so we can start syncing this repository into the Buf Schema Registry, alongside other common community Protobuf modules? (reference).

@unmultimedio unmultimedio mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proto: add package
3 participants
@derekperkins @unmultimedio @connorjclark