clients(extension): update some properties for manifest v3 #15347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adamraine
approved these changes
Aug 4, 2023
connorjclark
commented
Aug 4, 2023
| "browser_specific_settings": { | ||
| "gecko": { | ||
| "id": "{cf3dba12-a848-4f68-8e2d-f9fadc0721de}" | ||
| } |
There was a problem hiding this comment.
the flow for figuring out you need to add this exact string is:
- try to upload new extension package
- get error about no browser specific id with a link to https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/
- find https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#:~:text=Gecko%20versions.-,Extension%20ID%20format,-The%20extension%20ID
- go to some website and generate a GUID
- resubmit
- "your id does not match the id we expect: addasdd-ad-asda-sdas-dasd-as"
- "..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.