core(viewport-meta): include initial-scale value condition #15394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianaixba
commented
Aug 18, 2023
| return { | ||
| hasViewportTag: true, | ||
| isMobileOptimized: false, | ||
| parserWarnings: warnings, |
There was a problem hiding this comment.
in case this fails here, should we add a warning indicating the value of initial-scale is invalid?
There was a problem hiding this comment.
Nah, I think those warnings are for if the parser encountered an error. The signal to the user here will be the audit failing.
adamraine
reviewed
Aug 18, 2023
core/computed/viewport-meta.js
Outdated
| @@ -35,7 +35,16 @@ class ViewportMeta { | |||
| } | |||
|
|
|||
| const viewportProps = parsedProps.validProperties; | |||
| const isMobileOptimized = Boolean(viewportProps.width || viewportProps['initial-scale']); | |||
| const initialScale = viewportProps['initial-scale']; | |||
| if (initialScale && initialScale < 1) { | |||
There was a problem hiding this comment.
I don't think we need an extra if case here. WDYT about adding this condition to the isMobileOptimized calculation below.
adamraine
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail audit if the viewport's
initial-scalevalue is less than 1.fixes #15266