Extract chrome-launcher to a standalone thing. #2245
Conversation
|
Nothing too big in this PR, just renames and a move. generally lgtm. will fine-tooth it in a bit. |
| const assert = require('assert'); | ||
|
|
||
| /** | ||
| * THIS FILE IS A DUPLICATE OF lighthouse-core/test/global-mocha-hooks.js |
There was a problem hiding this comment.
do we really need to do this?
There was a problem hiding this comment.
good question. I defer to @paulirish
There was a problem hiding this comment.
nah. don't carry it over.
we'll delete these in a week. they haven't provided value in a long while.
|
we could also temporarily add a shim file in chrome-launcher.js |
That was my thought :) |
Since we are changing the API that is going to require a code change by any consumer, not sure we want this old path to work anymore. |
…se#2245) * Also extract default flags to standalone entity.
🚨 This is a breaking change to any consumer of the launcher 🚨
Pull chrome-launcher into a standalone folder and add a new standalone package.json.
This will enable us to publish chrome-launcher as a standalone module on npm for direct consumption.
PR action:
impacted users: 23~ on github
https://github.com/search?l=JavaScript&q=chrome-launcher.js&type=Code&utf8=%E2%9C%93
ref #2092