[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(gather-runner): always reset scroll position #9060

Merged
merged 4 commits into from
Jun 7, 2019
Merged

core(gather-runner): always reset scroll position #9060

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4c420e
Revert "misc(fix master): tmp revert of scroll change in #8625 (#9059)"
patrickhulce May 25, 2019
24883e9
fix merge conflicts
patrickhulce May 27, 2019
3b1ec54
fix testsg
patrickhulce May 27, 2019
add93d0
Update lighthouse-core/gather/gather-runner.js
patrickhulce Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix testsg
  • Loading branch information
@patrickhulce
patrickhulce committed May 27, 2019
commit 3b1ec54d9e7b33a9be2e233f6a7313a8e42894d4
4 changes: 3 additions & 1 deletion lighthouse-core/test/gather/gather-runner-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ describe('GatherRunner', function() {
endTrace: asyncFunc,
endDevtoolsLog: () => [],
getBrowserVersion: async () => ({userAgent: ''}),
getScrollPosition: async () => 1,
scrollTo: async () => {},
};
const passConfig = {
passName: 'default',
Expand Down Expand Up @@ -607,7 +609,7 @@ describe('GatherRunner', function() {
],
};

await GatherRunner.afterPass({url, driver, passConfig}, {TestGatherer: []});
await GatherRunner.afterPass({url, driver, passConfig}, {}, {TestGatherer: []});
// One time for the afterPass of ScrollMcScrolly, two times for the resets of the two gatherers.
expect(scrollToSpy.mock.calls).toEqual([
[{x: 1000, y: 1000}],
Expand Down